Implement to/from casting for extern w/ no allocation
#2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
reviewed
Mar 26, 2021
Hywan
approved these changes
Apr 1, 2021
Comment on lines
+19
to
+27
| /// All elements in this union must be `repr(C)` and have a | ||
| /// `CApiExternTag` as their first element. | ||
| #[allow(non_camel_case_types)] | ||
| pub(crate) union wasm_extern_inner { | ||
| function: mem::ManuallyDrop<wasm_func_t>, | ||
| memory: mem::ManuallyDrop<wasm_memory_t>, | ||
| global: mem::ManuallyDrop<wasm_global_t>, | ||
| table: mem::ManuallyDrop<wasm_table_t>, | ||
| } |
|
|
||
| #[allow(non_camel_case_types)] | ||
| #[derive(Clone)] | ||
| #[repr(transparent)] |
MarkMcCaskey
changed the title
wasm_extern_as_ no allocationextern w/ no allocation
|
bors r+ |
|
bors r- |
|
Canceled. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2197
This should be good to go now.
The only question is how we want to deal with a breaking change this big. @Hywan and I previously discussed this, it seems other implementers of the wasm C API may have the same bug this is fixing
New Changelog rendered
Primary Changelog rendered